Merged
Conversation
The fetcher copies old dockerfiles which already have maven-deps stages. Any new versions inherit those stages, then regenerate.go handles the pom.xml generation. Remove the unnecessary logic that was adding stages to dockerfiles and the regenerate-maven-poms CLI tool.
The pom.xml still needs to be regenerated for new plugin versions. Only the Dockerfile stage insertion was meant to be removed.
DMarby
requested review from
pkwarren and
stefanvanburen
and removed request for
stefanvanburen
stefanvanburen
approved these changes
Mar 13, 2026
pkwarren
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And the logic to add the stage to the dockerfiles, as all existing plugins that should have maven poms/deps stages have them, and any new versions gets them from the Dockerfile that gets copied from previous versions (and then the fetcher regenerates the .pom).